Skip to content

docs: add missing PermissionRequest hook event#88

Merged
sjnims merged 1 commit intomainfrom
docs/85-add-permissionrequest-hook-event
Dec 10, 2025
Merged

docs: add missing PermissionRequest hook event#88
sjnims merged 1 commit intomainfrom
docs/85-add-permissionrequest-hook-event

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 10, 2025

Summary

Add the missing PermissionRequest event to hook events documentation in two locations where it was omitted.

Problem

Fixes #85

The PermissionRequest hook event was missing from the hook events list in:

  • plugins/plugin-dev/skills/plugin-structure/SKILL.md:238
  • README.md:63

This event fires when a permission dialog is shown and is documented in the official Claude Code reference but was absent from this plugin's documentation.

Solution

Added PermissionRequest to both hook events lists, placing it between PreToolUse and PostToolUse to match the official documentation order.

Alternatives Considered

None - this is a straightforward documentation fix to align with official docs.

Changes

  • plugins/plugin-dev/skills/plugin-structure/SKILL.md: Added PermissionRequest to available events
  • README.md: Added PermissionRequest to hook events list

Testing

  • markdownlint passes
  • Verified order matches official Claude Code documentation

🤖 Generated with Claude Code

@sjnims @claude
docs: add missing PermissionRequest hook event
ef0a3c6 
Add PermissionRequest to the hook events list in plugin-structure skill
and README. This event fires when a permission dialog is shown and was
missing from the documentation despite being in the official Claude Code
reference.

Fixes #85

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sjnims sjnims mentioned this pull request Dec 10, 2025
Closed
2 tasks
@sjnims sjnims self-assigned this Dec 10, 2025
@claude
Copy link
Copy Markdown

claude Bot commented Dec 10, 2025 •
edited
Loading

Claude finished @sjnims's task —— View job

PR Review Complete ✅

Summary

Looks good - This is a straightforward documentation fix that correctly adds the missing PermissionRequest hook event to two documentation files.

What's Good

  1. Accurate Addition: The PermissionRequest event is indeed a valid hook event that was documented in the hook-development skill but missing from these two locations.

  2. Correct Placement: The event is correctly placed between PreToolUse and PostToolUse, matching the order used in:

    • plugins/plugin-dev/skills/hook-development/SKILL.md:3 (description)
    • plugins/plugin-dev/skills/hook-development/scripts/validate-hook-schema.sh:41 (VALID_EVENTS array)

  3. Complete Fix: Both occurrences where the event was missing have been addressed:

    • README.md:63 (Hook Development skill overview)
    • plugins/plugin-dev/skills/plugin-structure/SKILL.md:238 (Available events list)

  4. Markdown Quality: Passes markdownlint with no errors ✓

  5. Consistency: The event list now matches the comprehensive documentation in the hook-development skill, which already includes PermissionRequest with detailed usage examples (SKILL.md:162-184).

Checklist Verification

All Events Now Complete

The complete list of 10 hook events is now documented consistently:

  1. PreToolUse
  2. PermissionRequest ← Added by this PR
  3. PostToolUse
  4. Stop
  5. SubagentStop
  6. SessionStart
  7. SessionEnd
  8. UserPromptSubmit
  9. PreCompact
  10. Notification

This PR is ready to merge.

@claude claude Bot added documentation Improvements or additions to documentation component:skill Skills layer component:docs Documentation files effort:small < 1 hour labels Dec 10, 2025
@sjnims sjnims merged commit f4a1d74 into main Dec 10, 2025
8 checks passed
@sjnims sjnims deleted the docs/85-add-permissionrequest-hook-event branch December 10, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjnims sjnims

Labels

component:docs Documentation files component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs]: Add missing PermissionRequest hook event in plugin-structure skill

1 participant

@sjnims